Skip to content

Feature/net8 10#1855

Merged
david-driscoll merged 5 commits into
masterfrom
feature/net8-10
Mar 2, 2026
Merged

Feature/net8 10#1855
david-driscoll merged 5 commits into
masterfrom
feature/net8-10

Conversation

@david-driscoll
Copy link
Copy Markdown
Member

@david-driscoll david-driscoll commented Mar 2, 2026

No description provided.

@github-actions github-actions Bot added this to the v14.0.0 milestone Mar 2, 2026
@david-driscoll david-driscoll enabled auto-merge (squash) March 2, 2026 02:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2026 •
edited
Loading

Test Results

  2 files  ±0    2 suites  ±0   13m 9s ⏱️ - 4m 15s
664 tests ±0  562 ✅ ±0  102 💤 ±0  0 ❌ ±0 
751 runs  ±0  649 ✅ ±0  102 💤 ±0  0 ❌ ±0 

Results for commit 7f51639. ± Comparison against base commit 41a5d89.

This pull request removes 93 and adds 93 tests. Note that renamed tests count towards both. 
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(Exact, TestProject.A, TestProject.B, False)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(Exact, TestProject.A.Nested.ServiceA, TestProject.B.ServiceB, True)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(In, TestProject.A, TestProject.B, False)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(In, TestProject.A.Nested.ServiceA, TestProject.B.ServiceB, True)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(NotIn, TestProject.A.C, TestProject.B, False)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(NotIn, TestProject.A.C.ServiceC, TestProject.B.ServiceB, True)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Namespaces(Exact, TestProject.A, False, False)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Namespaces(Exact, TestProject.A.IService, True, False)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Namespaces(Exact, TestProject.A.IService, True, True)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Namespaces(In, TestProject.A, False, False)
…

Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(Exact, TestProject·A, TestProject·B, False)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(Exact, TestProject·A·Nested·ServiceA, TestProject·B·ServiceB, True)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(In, TestProject·A, TestProject·B, False)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(In, TestProject·A·Nested·ServiceA, TestProject·B·ServiceB, True)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(NotIn, TestProject·A·C, TestProject·B, False)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Multiple_Namespaces(NotIn, TestProject·A·C·ServiceC, TestProject·B·ServiceB, True)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Namespaces(Exact, TestProject·A, False, False)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Namespaces(Exact, TestProject·A·IService, True, False)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Namespaces(Exact, TestProject·A·IService, True, True)
Rocket.Surgery.DependencyInjection.Analyzers.Tests.StaticScanningTests ‑ Should_Filter_Namespaces(In, TestProject·A, False, False)
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2026 •
edited
Loading

Summary

Summary
Generated on: 03/02/2026 - 03:18:19
Coverage date: 03/02/2026 - 03:18:17
Parser: Cobertura
Assemblies: 8
Classes: 157
Files: 579
Line coverage: 70.3% (3915 of 5567)
Covered lines: 3915
Uncovered lines: 1652
Coverable lines: 5567
Total lines: 13993
Branch coverage: 70.7% (1322 of 1868)
Covered branches: 1322
Total branches: 1868
Method coverage: Feature is only available for sponsors
Tag: 14.0.0-pr.268+Branch.pull-1855-merge.Sha.16a731dead99c6949e0b6b3af6fb0bd5f42d2d72

Coverage

Rocket.Surgery.DependencyInjection.Analyzers - 89%
Name Line Branch
Rocket.Surgery.DependencyInjection.Analyzers 89% 80.8%
MyAssembly.Info 0%
MyAssembly.Metadata 0%
MyAssembly.Project 0%
Rocket.Surgery.DependencyInjection.Analyzers.AnyTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection 76% 85.1%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollection.Item 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyCollectionData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderBuilder 100% 95.4%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviderConfiguration 94% 87%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.AlwaysMatchT
ypeFilter		 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledAsse
mblyFilter		 97% 50%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledServ
iceTypeDescriptors		 28.5% 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.CompiledType
Filter		 100% 91.6%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.DataHelpers 95.8% 75.1%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.FindTypeInAs
sembly		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.FindTypeVisi
tor		 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.MustBeAnExpr
essionException		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitorBase		 100% 80%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblyProviders.TypeSymbolVi
sitorExtensions		 18.1% 0%
Rocket.Surgery.DependencyInjection.Analyzers.AssemblySymbolExtensions 100% 80%
Rocket.Surgery.DependencyInjection.Analyzers.AssignableToAnyTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.AssignableToTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.CompiledAssemblyProviderData 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.CompiledTypeProviderGenerator 100% 87.5%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AllAssemblyDescrip
tor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssemblyDependenci
esDescriptor		 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssemblyDescriptor 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssignableToAnyTyp
eFilterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.AssignableToTypeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.CompiledServiceTyp
eDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.ImplementedInterfa
cesServiceTypeDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.IncludeSystemAssem
bliesDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NameFilterDescript
or		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NamespaceFilterDes
criptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssemblyDescrip
tor		 50%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssignableToAny
TypeFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.NotAssignableToTyp
eFilterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.TypeInfoFilterDesc
riptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.TypeKindFilterDesc
riptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.UnknownCompiledSer
viceTypeDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAnyAttributeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAnyAttributeSt
ringFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAttributeFilte
rDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithAttributeStrin
gFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithoutAttributeFi
lterDescriptor		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Descriptors.WithoutAttributeSt
ringFilterDescriptor		 0%
Rocket.Surgery.DependencyInjection.Analyzers.Diagnostics 100%
Rocket.Surgery.DependencyInjection.Analyzers.GeneratedAssemblyProviderData 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.GeneratedLocationAssemblyResol
vedSourceCollection		 100% 100%
Rocket.Surgery.DependencyInjection.Analyzers.GetAssemblyConfiguration 100%
Rocket.Surgery.DependencyInjection.Analyzers.GetReflectionCollectionData 100%
Rocket.Surgery.DependencyInjection.Analyzers.GetServiceDescriptorCollection
Data		 100%
Rocket.Surgery.DependencyInjection.Analyzers.Helpers 82.9% 65.2%
Rocket.Surgery.DependencyInjection.Analyzers.NameFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.NamespaceFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection 75.2% 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollection.Item 100%
Rocket.Surgery.DependencyInjection.Analyzers.ReflectionCollectionData 100%
Rocket.Surgery.DependencyInjection.Analyzers.ResolvedSourceLocation 100%
Rocket.Surgery.DependencyInjection.Analyzers.ResultingAssemblyProviderData 100% 87.5%
Rocket.Surgery.DependencyInjection.Analyzers.ResultingLocationAssemblyResol
vedSourceCollection		 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection 88.4% 85.7%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollection.It
em		 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorCollectionDat
a		 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceDescriptorFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.ServiceTypeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.SourceLocation 100%
Rocket.Surgery.DependencyInjection.Analyzers.StatementGeneration 89.8% 77.7%
Rocket.Surgery.DependencyInjection.Analyzers.SwitchGenerator 96.5% 88.2%
Rocket.Surgery.DependencyInjection.Analyzers.TypeFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.TypeInfoFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.TypeKindFilterData 100%
Rocket.Surgery.DependencyInjection.Analyzers.WithAttributeData 100%
Rocket.Surgery.DependencyInjection.Analyzers.WithAttributeStringData 0%
Rocket.Surgery.DependencyInjection.Extensions - 74.1%
Name Line Branch
Rocket.Surgery.DependencyInjection.Extensions 74.1% 37.5%
MyAssembly.Info 0%
MyAssembly.Metadata 0%
MyAssembly.Project 0%
Rocket.Surgery.DependencyInjection.Compiled.CompiledTypeProviderAttribute 80%
Rocket.Surgery.DependencyInjection.Compiled.CompiledTypeProviderExtensions 100% 50%
Rocket.Surgery.DependencyInjection.Compiled.ExcludeFromCompiledTypeProvider
Attribute		 0%
Rocket.Surgery.DependencyInjection.Compiled.ICompiledTypeProvider 0% 0%
Rocket.Surgery.DependencyInjection.ExecuteScoped 100%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4, T5, T6> 100%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4, T5> 100%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3, T4> 100%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2, T3> 100%
Rocket.Surgery.DependencyInjection.ExecuteScoped<T1, T2> 100%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional 100%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4, T5
, T6>		 100%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4, T5
>		 100%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3, T4> 100%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2, T3> 100%
Rocket.Surgery.DependencyInjection.ExecuteScopedOptional<T1, T2> 100%
Rocket.Surgery.DependencyInjection.RegistrationLifetimeAttribute 0%
Rocket.Surgery.DependencyInjection.ScopedServiceExtensions 50%
Rocket.Surgery.DependencyInjection.ScopedServiceOptionalExtensions 50%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2, TService3, TService4>		 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2, TService3>		 0%
Rocket.Surgery.DependencyInjection.ServiceRegistrationAttribute<TService1,
TService2>		 0%
Rocket.Surgery.Extensions - 67.8%
Name Line Branch
Rocket.Surgery.Extensions 67.8% 72.2%
MyAssembly.Info 0%
MyAssembly.Metadata 0%
MyAssembly.Project 0%
Rocket.Surgery.Extensions.Encoding.Base3264Encoding 93.7% 85.7%
Rocket.Surgery.Extensions.Encoding.Base32Url 87.9% 81.5%
Rocket.Surgery.Extensions.Encoding.Base32Url.CharMap 70% 62.5%
Rocket.Surgery.Extensions.Encoding.Base64Url 100% 100%
Rocket.Surgery.Extensions.NullableExtensions 73.4% 57.1%
Rocket.Surgery.Extensions.TopographicalSortExtensions 0% 0%
Rocket.Surgery.Extensions.Binding - 64%
Name Line Branch
Rocket.Surgery.Extensions.Binding 64% 76.3%
MyAssembly.Info 0%
MyAssembly.Metadata 0%
MyAssembly.Project 0%
Rocket.Surgery.Binding.BackingFieldValueProvider 70%
Rocket.Surgery.Binding.JsonBinder 79.1% 77%
Rocket.Surgery.Binding.JsonBinderExtensions 100% 100%
Rocket.Surgery.Binding.PrivateSetterContractResolver 93.7% 72.7%
Rocket.Surgery.Extensions.Logging - 13.7%
Name Line Branch
Rocket.Surgery.Extensions.Logging 13.7% 50%
MyAssembly.Info 0%
MyAssembly.Metadata 0%
MyAssembly.Project 0%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions 26.3% 50%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions.Disposable 0%
Rocket.Surgery.Extensions.Logging.LoggingAbstractionsExtensions.NoopDisposa
ble		 100%
Rocket.Surgery.Reactive.Extensions - 0%
Name Line Branch
Rocket.Surgery.Reactive.Extensions 0% ****
MyAssembly.Info 0%
MyAssembly.Metadata 0%
MyAssembly.Project 0%
Rocket.Surgery.Reflection.Extensions - 43.6%
Name Line Branch
Rocket.Surgery.Reflection.Extensions 43.6% 40%
MyAssembly.Info 0%
MyAssembly.Metadata 0%
MyAssembly.Project 0%
Rocket.Surgery.Reflection.BackingFieldHelper 77.5% 56.6%
Rocket.Surgery.Reflection.InjectableMethodBuilder 70.5% 37.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10, T11, T12>		 24.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10, T11>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9, T10>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8, T9>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
, T8>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6, T7
>		 25.3% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5, T6> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4, T5> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3, T4> 25.4% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2, T3> 25.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder<T, T2> 25.5% 12.5%
Rocket.Surgery.Reflection.InjectableMethodBuilder 46.1% 25%
Rocket.Surgery.Reflection.InjectableMethodBuilderBase 96% 92.8%
Rocket.Surgery.Reflection.MethodNotFoundException 0%
Rocket.Surgery.Reflection.PropertyDelegate 33.3% 25%
Rocket.Surgery.Reflection.PropertyGetter 33.5% 23.5%
Rocket.Surgery.Reflection.TypeDelegate 86.9% 77.5%
Rocket.Surgery.Reflection.TypeDelegate.Info 100% 100%
Rocket.Surgery.Reflection.TypeExtensions 100% 100%
Rocket.Surgery.Reflection.TypeInfoExtensions 0% 0%
Rocket.Surgery.Reflection.ValueExtensions 0%
TestAssembly - 0%
Name Line Branch
TestAssembly 0% ****
MyAssembly.Info 0%
MyAssembly.Metadata 0%
MyAssembly.Project 0%

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 2, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 96.12403% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.95%. Comparing base (41a5d89) to head (7f51639).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ers/Configuration/AssemblyProviderConfiguration.cs 95.96% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1855      +/-   ##
==========================================
- Coverage   74.01%   73.95%   -0.06%     
==========================================
  Files         107      107              
  Lines        5049     5038      -11     
  Branches      441      441              
==========================================
- Hits         3737     3726      -11     
  Misses       1165     1165              
  Partials      147      147

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-driscoll david-driscoll merged commit dc9442d into master Mar 2, 2026
8 checks passed
@david-driscoll david-driscoll deleted the feature/net8-10 branch March 2, 2026 03:19
@github-actions github-actions Bot added the ✨ mysterious We forgot to label this label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

✨ mysterious We forgot to label this

Projects

None yet

Milestone

v14.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@david-driscoll @rsg-bot